[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Excessive use of TCP sockets

From: Thomas Hallgren <thomas_at_tada.se>
Date: 2007-06-14 17:45:21 CEST

My fault. I was looking at the source from tags/svnClientAdapter/0.9.4.
I incorrectly assumed that to be the latest since I didn't realize that
the module had moved to below the subclipse folder.

But now I'm looking at a more recent version and the question remains.
But this time for the SVNClient.dispose().

- thomas

Mark Phippard wrote:
> I believe we stopped using the SVNClientSynchronized class before the
> 1.0.0 release. Where do you see that class being used?
>
> It just calls the dispose method of SVNClient, which we do use. But I
> do not believe its dispose() method needs to be called regardless.
>
> Mark
>
>
> On 6/14/07, Thomas Hallgren <thomas@tada.se> wrote:
>> I'm looking at the source for the JhlClientAdapter class. It uses a
>> SVNClientSynchronized. That class has a dispose() method. From what I
>> can see, it never gets called and there's no way for me to get to it.
>> Could this be the reason why I see so many sockets that are lingering in
>> TIME_WAIT? We do implicitly create many instances of the client adapter.
>>
>> - thomas
>>
>>
>>
>> Mark Phippard wrote:
>> > On 5/18/07, Thomas Hallgren <thomas@tada.se> wrote:
>> >> The subject refers to a Buckminster bug
>> >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=186092 that would like
>> >> your input on.
>> >>
>> >> Buckminster uses several instances of ISVNClientAdapter (one per
>> project
>> >> that it resolves and eventually downloads). We use the following
>> >> commands used on the adapter:
>> >>
>> >> getList(SVNUrl, SVNRevision, boolean)
>> >> getContent(SVNUrl, SVNRevision)
>> >> getDirEntry(SVNUrl, SVNRevision)
>> >> checkout(SVNUrl, File, SVNRevision, boolean)
>> >>
>> >> This seems to result in a lot of TCP sockets lingering in a TIME_WAIT
>> >> until they are closed due to a timeout. Is there clean-up needed
>> on the
>> >> ISVNClientAdapter to avoid this? Any other ideas?
>> >
>> > Our code lives several layers above something like that. You'd have
>> > to write some tests that show your problem and take it up with the
>> > adapter provider, JavaHL or SVNKit.
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
>> For additional commands, e-mail: dev-help@subclipse.tigris.org
>>
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Thu Jun 14 17:45:58 2007

This is an archived mail posted to the Subclipse Dev mailing list.