[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Issue 591: Expand All Toolbar Icon for Synchronize View

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-03-07 17:47:17 CET

On 3/6/07, Jeremy Whitlock <jcscoobyrs@gmail.com> wrote:
>
> Hi All,
> I have just submitted a patch to Issue 591. This issue is nearly
> complete but the toolbar icon is not in the right place. I spoke with Mark
> and he suggested submitting the patch before completion to get other
> people's eyes on it. Here is the direct link to the issue with the patch
> and icon:
>
> http://subclipse.tigris.org/issues/show_bug.cgi?id=591
>
> To describe the remaining issue to work out is the fact that the "Expand
> All" toolbar icon is at the beginning of the toolbar group instead of at the
> end. Anyone who can help me finish this issue would be great. If I do end
> up figuring up what is wrong, I will update the patch.

I had someone look at it and they concluded that you cannot control the
location of the icon within the group. We tried putting it in different
groups, but the way you did it looks best.

Committed in r3000!!

Thanks for the patch.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on Wed Mar 7 17:47:29 2007

This is an archived mail posted to the Subclipse Dev mailing list.