[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Another bug in new locking code in 1.1.9

From: Mark Phippard <markphip_at_gmail.com>
Date: 2006-12-24 15:35:08 CET

On 12/23/06, Mark Phippard <markphip@gmail.com> wrote:
>
>
> I am not going to attempt to tackle the error dialog issue. I do not
> disagree with the idea, but I also think we have the Console and that
> is what it is for. Imagine a refactor process that was locking 10-20
> files.
>
> Your analysis of the error and its importance are all correct. I
> think you gave me enough to fix it when I get some time after the
> holiday.

I committed a fix to trunk if you want to try it. I now only attempt to
lock files with the svn:needs-lock property set. It still uses the read
only attribute as a hint to begin the process, but files that are read only
but do not have the property set will not just be offered to make writable.
Only files with the svn:needs-lock property set get offered to lock. This
let us remove the workaround I had added to the Lock code to make the files
writable and just makes it all more accurate.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on Sun Dec 24 15:35:16 2006

This is an archived mail posted to the Subclipse Dev mailing list.