Mark Phippard wrote:
>> I actually think that this dialog, API and extension points belongs
>> to the Eclipse's Platform Team component.
>> Ideally we should have some kind of abstract class available to all
>> interested parties and that class should take care of the list of
>> resources for commit. However comment area and additional stuff that
>> specific to issue tracking systems should be pluggable. So, 3rd party
>> plugins can register and provide their own implementation.
>> This can be of course implemented in Mylar, but I think that not
>> everybody would want dependency on Mylar components. Michael can
>> correct me, but I am not sure if there is an enhancement request for
>> Eclipse. Though I recall there is a request to make commit an API.
> I am not sure if a common commit dialog would be of that great of
> benefit. I suppose it would depend on how many cool additions it
> could have. Such as issue tracking integration, and maybe integrated
> compare view? But as an example, there are some bits of essential
> SVN-specific info we show for the files that I would not want to give
> up. That means we have to supply that piece of the UI, at which point
> what is the common dialog still providing us?
Good point. But then we have second half of that dialog with comments
and issue trackers integration that should be shared between Subclipse,
Team/CVS, etc. plugins.
It sounds like we need two extension points for UI pieces here. One
specific to version control, and the other specific to comments and
issue tracking stuff.
Or maybe that dialog may accept arbitrary number of panels related to
commit activities, including pre-commit validation and stuff like that.
>> I also think that using bugtraq:type property in Subclipse may not
>> be flexible enough. For instance it will be a duplication of the same
>> info that Mylar or Maven already have. Note that Mylar already can
>> link issue tracking repositories to Eclipse projects (though that may
>> not work for remote resources yet) and that link can be made
>> extendable to actually pull that info from Maven's metadata (pom.xml).
> I assume if we integrate with a Mylar extension point we would not
> need any SVN properties. It would just recognize and use the Mylar
> config.
I did that because Mylar may have issue tracker repository registered,
but that repository may not be linked to the projects. So, these
Subclipse properties are used as additional metadata to establish such
link. For example, Subclipse's own projects don't have Mylar's
properties (yet?), but some of them (I wonder why not all) do have issue
tracking properties set, so issue tracking repository resolution is
working for them.
regards,
Eugene
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Mon Nov 27 22:09:40 2006