[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Re: [Subclipse-users] 1.1.8 and icons

From: Denny <valliant_at_unm.edu>
Date: 2006-11-06 23:39:10 CET

Mark Phippard wrote:
> Jörg Eichhorn <jeichhorn@gmail.com> wrote on 11/05/2006 05:59:15 AM:
>
>> As i said, the icons will change to the selected icon set when the ui
> plugin
>> is loaded.
>
> I am not convinced this explains it. I had the Subversive icon set
> selected, and my test environment was loaded with Subclipse projects, but
> I did not have any icons at all. How could the UI plugin not have been
> loaded? Where would all of the decorators come from if it was not loaded?

Ditto. Not sure why the existing icons would be working with the
current setup, but not with duplicated actions.

>> Would it make sense to automatically let the ui plugin loaded on eclipse
>
>> startup? Imho this wouldn't hurt, because someone who has subclipse
> installed
>> will use it anyway.
>
> People have objected to this sort of stuff in the past. But I do not
> think it would be too big of a deal if it can solve the problem.

I just don't see how this could be the real culprit.

When I run from source, I'm not seeing any icons at all. Don't know if
this is something wrong with my setup, or what. The three actions I
added to their own toolbar showed with their hard-coded icons though...
I reverted just to see if it was the new toolbar set, but nope, still no
icons. Strange. Yet when I run the compiled fresh source in my normal
eclipse install, I see icons.

        Un-checking the "activate plugin when class is loaded" box made running
from source impossible, eclipse just hung about 3/4ths of the way
through starting up.
Must be something wrong with my setup, as I'm guessing that didn't
happen for whoever suggested un-checking that box.

If it were up to me, I'd say add the toolbar action set with icons
hard-coded to the tortoise iconography, and see if anyone complains
about the sets not matching... and if they do, say "we're too busy to
mess with eye candy, submit a patch". Or, "when CVS comes up with
something a little less bleak" maybe.

        I am a lazy coder though, and many times take the one in the hand for
two in the bush type-deal. The patch attached to the new issue for this
only effects plugin.xml and plugin.properties, which I like better than
touching the other files. And, I suspect, is really all that's needed.
 But it's just a suspicion, perhaps we do need to change
start up order or whatnot... IANAG. =]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Mon Nov 6 23:39:21 2006

This is an archived mail posted to the Subclipse Dev mailing list.