[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] [BUG][svnClientAdapter] Problem with SVNStatusUtils.isManaged

From: Mark Phippard <markp_at_softlanding.com>
Date: 2006-10-19 17:25:22 CEST

Mark Phippard <markp@softlanding.com> wrote on 10/19/2006 11:22:16 AM:

> Manfred Klug <manklu@web.de> wrote on 10/19/2006 11:07:27 AM:
>
> > > Manfred Klug <manklu@web.de> wrote on 10/08/2006 02:37:43 AM:
> > >
> > > > isManaged based on the text status does not work reliably, since
an
> > > > unversioned or ignored folder may have a text status of external
> which
> > > > is interpreted as managed.
> > >
> > > Are you talking about something like a multi-folder svn:externals
> > > property. I know when svn processes this it will create folders
that
> have
> > > no .svn folders until it gets down to the final folder. Is that the

> > > scenario you mean?
> >
> > This is the scenario where I have detected the problem.
> >
> > > Do you have a suggested fix?
> >
> > If LocalResourceStatus would contain the repository revision, I could
> fix it.
>
> It has the lastChangedRevision, wouldn't that be good enough?
>
> I was thinking that maybe in ResourceStatus where it stores the text
> status, if it has a value of EXTERNAL and the lastChangedRevision < 1 we

> could change it to UNVERSIONED?

What about something like this? I thought IGNORED might be better? I
have not tested.

Index:
C:/tsvn/Subclipse/repos/trunk/subclipse/core/src/org/tigris/subversion/subclipse/core/resources/ResourceStatus.java
===================================================================
---
C:/tsvn/Subclipse/repos/trunk/subclipse/core/src/org/tigris/subversion/subclipse/core/resources/ResourceStatus.java
(revision 2792)
+++
C:/tsvn/Subclipse/repos/trunk/subclipse/core/src/org/tigris/subversion/subclipse/core/resources/ResourceStatus.java
(working copy)
@@ -112,6 +112,9 @@
         this.nodeKind = status.getNodeKind().toInt();
 
         this.file = status.getFile();
+
+ if (this.textStatus == SVNStatusKind.EXTERNAL.toInt() &&
this.lastChangedRevision < 1)
+ this.textStatus = SVNStatusKind.IGNORED.toInt();
        }
 
     public String toString()

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Thu Oct 19 17:25:35 2006

This is an archived mail posted to the Subclipse Dev mailing list.