[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Eclipse 3.1/3.2 Support

From: Denny Valliant <valliant_at_unm.edu>
Date: 2006-05-28 02:12:38 CEST

Hash: SHA1

Mark Phippard wrote:
> I think it would also be nice if someone wanted to revisit the Key-binding
> issue. I think that one got stuck when we were requiring 3.0 compliance
> in trunk.

The key-binding had a couple of issues, but they weren't related to 3.0.
 That was my other attempt at a contribution, the repository export via
eclipse prefs. export. I'll update that issue in case we want to try it

As for the key-binding, I finally figured out how to get it to work from
the active editor part (before it used the navigator/package explorer
for "current" selection), but someone should look over the
selectionChanged() modifications just in case. Only two issues left, 1
being the fact that the key-bindings stop working if you hide the action
set, and 2 being one that just popped up:

if I remove this:

        public CommitAction(String proposedComment) {
                this.proposedComment = proposedComment;

from ui/actions/CommitAction.java, the commit key-binding will load.
Otherwise it chokes.

Why is that? Any guesses/shots in the dark?

I haven't updated the issue with the code from this latest attempt, but
I can if someone wants to try to bang out the whys of it themselves.

I'd really love to get this working. I feel a little guilty that I've
been using key-bindings for months now, yet haven't gotten it good
enough for trunk.


- -ps here is the choke error:
        at java.lang.Class.newInstance0(Unknown Source)
        at java.lang.Class.newInstance(Unknown Source)
Version: GnuPG v1.4.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Sun May 28 02:12:52 2006

This is an archived mail posted to the Subclipse Dev mailing list.