[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-dev] [PATCH] navigation to files from "SVN" console view.

From: Alexander Kitaev <alex_at_tmate.org>
Date: 2006-02-23 21:20:26 CET

Hello Mark,

> Brock, I know you had done some work on the Console that we
> had to pull out because it required Eclipse 3.1. This patch
> also requires Eclipse 3.1. It seems inevitable that we are
> going to need to make trunk require 3.1. Do you want to
> review and commit this as well as your previous enhancements
> to Console?
I will add some comments on that:

I worked more on pathMatcher (code that matches paths in console and allows
navigation to files) from the time I sent a patch to the list and now it
should work both with JavaSVN and JavaHL (at least on my computer JavaHL
relative paths are always in form of workspaceDirName/path, this allows to
match a file). Also, currently this code exists as a plugin that could be
installed separately, and works (tested) with Eclipse 3.2M4 and M5. May be I
will publish it on tmate.org update site to let users test it before
committing to Subclipse code base. I, personally, find it very useful.

In attached file please find the latest version of the path matcher class
(feel free to change package and remove license header before committing
into Subclipse).

Alexander Kitaev,
TMate Software,
http://tmate.org/
http://jetbrains.com/tmate/

> -----Original Message-----
> From: Mark Phippard [mailto:markp@softlanding.com]
> Sent: Thursday, February 23, 2006 20:56
> To: dev@subclipse.tigris.org
> Subject: RE: [Subclipse-dev] [PATCH] navigation to files from
> "SVN" console view.
>
> "Alexander Kitaev" <alex@tmate.org> wrote on 02/13/2006 09:16:24 AM:
>
> > > Out of curiosity, did you test it with both adapters? I
> recall that
> > > one of them outputs full paths and the other relative paths. I
> > > could be wrong. It seems like relative paths would be more
> > > difficult to implement this feature with.
> >
> > I tested it only with JavaSVN. Currently it should match paths that
> starts
> > with "X:/" or just with "/".
> > The matcher doesn't match all paths however, currently pattern looks
> like:
> >
> > "[whitespace]+[AUCDGMRS][whitspace]+PathPattern(any string till the
> > end
> or
> > till the line separator)".
> >
> > There are also patterns for lines that includes words "Sending",
> "Deleting",
> > "Replacing", "Adding" and "Reverted" instead of single
> character status.
> >
> > PathPattern part of regexp could be easily changed to match any
> > string,
> and
> > I think this still will work.
> >
> > PS I've just noticed that I forgot to include "S" status character
> > into
> the
> > pattern, please add it.
>
> Brock, I know you had done some work on the Console that we
> had to pull out because it required Eclipse 3.1. This patch
> also requires Eclipse 3.1. It seems inevitable that we are
> going to need to make trunk require 3.1. Do you want to
> review and commit this as well as your previous enhancements
> to Console?
>
> I'd also like to see your work on Commit Sets either be
> committed or discussed as to what the options are. If you
> can make your code work with
> 3.1 and 3.2 using the Internal classes it might be worth
> committing it for now.
>
> Thanks
>
> Mark
>
>
>
>
> ______________________________________________________________
> _______________
> Scanned for SoftLanding Systems, Inc. and SoftLanding Europe
> Plc by IBM Email Security Management Services powered by MessageLabs.
> ______________________________________________________________
> _______________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org

Received on Thu Feb 23 21:18:32 2006

This is an archived mail posted to the Subclipse Dev mailing list.