First of all it is not about CVS, but about generic Team
infrastructure. Unfortunately it had been mostly used for CVS plugin,
but there are lot of ideas and features already in place ready to be
picked up and used.
Let me enumerate what you are trying to do in that modal commit dialog:
1. See list of changed files/properties
2. Select some of those files for commit
3. Be able to see changes (open comparison tool) for each of those files.
4. Prepare comment for commit
Did I miss anything?
Anyways, all of those actions can be done from Synchronize view and
all of them (exept entering commit comment) can be done without a single
dialog (comparison tool is an editor I was talking about in my previous
email).
You should really learn in depth how those things are done for CVS
plugin before going into discussion. I've been using both Subclipse and
CVS in Eclipse long enough to say that Eclipse CVS integration is most
convenient and rock solid one I ever seen (from the feature set and UI
ergonomics) and Subclipse is still have to catchup with that. Major
missing features are incoming and outbound change sets.
regards,
Eugene
Denny Valliant wrote:
> Eugene Kuleshov wrote:
>
>> Guys, maybe you should stop inventing new view and fooling around
>> with those dialogs? It is all already there.
>>
>> View you are looking for is called Synchronize view and it is
>> provide all the infrastructure to see changes and call comparison
>> _editors_.
>>
>> With a correspond data provider it would also allow to group
>> outgoing changes together before committing (either manually or using
>> some tools, e.g. Mylar).
>>
>> regards,
>> Eugene
>
> That's swell Eugene, I love the sync view, but you'll find I was
> talking about something sorta different. It really stems from your
> observant comment about _editors_. There are sync options that
> require editing (or grouping, or whatever). I don't have any trouble
> with extending the sync view more, that would be a logical place to do
> it.
>
> So I assume you favor a pane or some such that splits the view and
> contains space for writing log text or whatever? Or what? I was
> looking more for ideas, like specific ideas, vs. another general
> idea. Sure we have a sync view, and that is a logical place to put
> sync related info, but *how* would you use the sync view instead of
> the dialogs or a different view or whatever? See what I mean? Looking
> for actual ideas that could have pro's and con's discussed and whatnot.
>
> Like, what you could have said was, "Hey, I understand what you are
> talking about with the modal dialogs and such, and I've been thinking
> about it too, and I think that the commit dialog could be a split pane
> in the sync view vs. the current dialog." I doubt that's what you
> meant, but you get the drift... or "I happen to really like the modal
> dialogs and think they should stay" or whatever...
>
> I don't think we have to do everything the way CVS does it either, so
> I'm not gonna say something is good just because that's the way it's
> been done before, or whatever. I'm looking for practical, intuitive,
> whatnot. Same crap everyone wants. Not that I'd do anything with any
> practical ideas or whatever, I just wanted to see what you thought.
> Seriously tho, ya know, actual "we could do it like this, or like
> that, or like this and uh" type suggestions. So they could be torn
> apart or whatever and I'd get some knowledge and maybe we'd come up
> with ideas that are in the middle enough so they're useful to a wide
> audience and don't go against the grain of SVN and whatnot.
>
> I know you've got some ideas Eugene, if you aren't too invested in
> them, I'd like to hear what you got...
>
> Thanks!
>
>>
>>
>> Denny Valliant wrote:
>>
>>> Mark Phippard wrote:
>>>
>>>> "Jesper Moller" <jesper@selskabet.org> wrote on 01/27/2006 10:10:03
>>>> AM:[...]
>>>>
>>>>
>>> > I have a different idea which I put into
>>> > the bug report, to make a new compare
>>> > dialog (which is neccessary anyway to
>>> > fix the issue with the file being editable
>>> > and the wrong buttons) which also has
>>> > a commit message edit field, so you
>>> > could "carry the text around" while
>>> > looking at the diffs for each file.
>>>
>>> It could be the commit view!
>>>
>>> Then throw in spell checking, class/file
>>> name completion, and a bunch of other
>>> stuff for the log text! :-)
>>>
>>> :-) I love the patch.
>>> **
>>> I had this sitting in "Drafts" and thought
>>> what the hell, it's an idea. The comments
>>> about the latest patch submission (thanks
>>> author of patch:) for unversioned resources
>>> got me to thinking that maybe Mark was
>>> onto something when he was talking about
>>> getting rid of the modal dialog... and thus,
>>> why not send this out, as an idea? A view
>>> for the various actions vs. the dialog?
>>>
>>> Eh. Guess the hard part is the design, not
>>> the idea, but I'd like to second the nixing
>>> of the modal dialog... or maybe keep
>>> the dialog, but add a view, where we
>>> could stick some features that the dialog
>>> doesn't have space for? "Extended"
>>> actions maybe? Something like that?
>>>
>>> I was just liking the idea of non-modal
>>> but having trouble concieving how, and
>>> thought, hey, maybe Mark or someone
>>> else has thought of a philosophy regard'n
>>> the idea, or whatever.
>>>
>>> If that was Mark that proposed it even.
>>>
>>> Just idle thoughts, sorta...
>>>
>>> Thanks,
>>> -denny
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Tue Feb 7 04:38:40 2006