[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] [PATCH] delete unmanaged/filter conflics patch - Take II

From: Paul Lorenz <plorenz_at_gmail.com>
Date: 2006-02-07 01:53:35 CET

On 2/3/06, Mark Phippard <markp@softlanding.com> wrote:
> Paul Lorenz <plorenz@gmail.com> wrote on 02/03/2006 09:11:22 AM:
>
> > > 2) In plugin.properties, you seemed to add the same literal twice.
> > >
> > I wasn't sure what the convention was if you're using the same text in
> > two different places in the UI. I guess if some time later we want
> > different text in those places, we can add another literal, so I'll
> > take that one out.
>
> What I was talking about was a place where everything was the same (the
> key and the value). Maybe the key was slightly different and I missed it?
>
> > > 3) The Non-SVN Conflicts filter is on by default. It doesn't seem
> like
> > > it should be.
> > Ok, I'll look at that. Not sure where that gets set.
>
> Can you also separate this patch? If I decide to backport any of these to
> the 1.0.x branch I would prefer that they be in separate commits.
>
> > > 4) I am mildly concerned that people will not understand what Delete
> > > unmanaged resources means. Technically the item is Added, and will
> become
> > > unmanaged as part of the revert. Also, other items that are unmanaged
> > > will not be deleted because they would not have shown in the revert
> > > dialog. I do not have any great ideas here on how to improve it.
> > >
> > I was thinking about what files show up in the revert dialog, and
> > wondering if we could have unmanaged resources show up there, so that
> > they would be deleted if the delete unmanaged resources option were
> > set. Is this something you would consider? Or maybe it's different
> > enough that it should be it's own operation? It's still an operation
> > which does something related to the repository state.
>
> I was starting to think we should change the approach to a separate
> option. Leave revert alone, and instead have a new option that bring up
> all Unversioned resources. The dialog could have options to Add them, or
> delete them. I am not sure what we would call it.
>

Ok, so now that the conflicts filter is under review, I'm back to
thinking about the delete unmanaged resources. How about a "Revert and
Clean" option that would do a revert and also delete any unmanaged
resources? It would behave much like Revert, except that in addition
to whatever resources would normally show up in the Revert dialog, any
unmanaged resources that were selected, or implied via recursion would
also show up, and if selected, would be deleted.

I like this better than the the list unversion resources because it
gives you a one step process to return a worspace, folder or sync view
back to a pristine state. Though, I could see both being useful.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Tue Feb 7 01:53:41 2006

This is an archived mail posted to the Subclipse Dev mailing list.