[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Added compare to commit dialog.

From: Mark Phippard <markp_at_softlanding.com>
Date: 2006-01-27 15:58:28 CET

"Jesper Moller" <jesper@selskabet.org> wrote on 01/27/2006 10:10:03 AM:

> >Mark Phippard <markp@softlanding.com> wrote on 01/27/2006 08:45:02 AM:
> >
> >One thing that may not have been clear, I am +1 on this change and
thanks
> >for doing it. I was just posting my reasons why I had not done it yet.
 I
> >have been thinking of ways to have the commit dialog itself have an
> >expanded view to show the compare, and just had not had the motivation
to
> >try it.
>
> This will create one big, fat dialog. Perhaps this is better, though.

Yeah, I doubt it would work too well. Obviously it would be some kind of
Show/Hide thing.

> I have a different idea which I put into the bug report, to make a new
compare
> dialog (which is neccessary anyway to fix the issue with the file being
> editable and the wrong buttons) which also has a commit message edit
field, so
> you could "carry the text around" while looking at the diffs for each
file.

That might work, but I fear it would be a bit too unexpected for most
users to comprehend.

> >Other option would be to work on making the commit dialog modeless and
> >then open the compare in normal editor. I think that idea opens a lot
of
> >possibilities for buggy commit behavior.
>
> Mabye make the Pending Operations View (of which I'm very fond) a
sashform
> with an editing field to type the commit message into, and when the user

> clicks commit, carry that text into the editor?
>
> Mabye rename it "Pending Commit View"... That's a wholly different
approach,
> but in a way it accomplishes the same goal.

This would be a pretty radical change. I do not think any of these would
be qualified for 1.0. I assume you are doing this already, but I would
focus on fixing the immediate problems with your current approach so that
we can include in 1.0. Then take it from there.

It sounds like there are people working on Commit Sets in the Synch view,
and it is possible that would address some of these needs.

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Fri Jan 27 16:27:36 2006

This is an archived mail posted to the Subclipse Dev mailing list.