[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Added compare to commit dialog.

From: Mark Phippard <markp_at_softlanding.com>
Date: 2006-01-27 14:45:02 CET

"Jesper Moller" <jesper@selskabet.org> wrote on 01/27/2006 05:14:30 AM:

> A colleague of mine teased that TortoiseSVN could show a compare dialog
> the commit dialog, which I admit is a pretty useful thing. So I added
this in
> r2086 in trunk.
> It's a very straightforward patch - perhaps consider for the next 1.0

You should update issue #409


I have used this feature in TortoiseSVN. One of the reasons I did not
want to do it in Subclipse yet is that our solution is all done with modal
dialogs. The use-case that is generally put forth for this feature is
that people want to have a diff open so that they can use that to write
their commit message. So I was holding off for some kind of inspiration
as to how to solve the problem.

I did some testing and did find a few issues:

1) The compare dialog has a button labeled Commit. I think it should be
Save or OK.

2) I think it is a bad idea that the dialog allows stuff to be edited.
That could change the status of the item in terms of the commit dialog.
For example, what if you undo all of the changes in the compare dialog?

3) When I did edit something in the dialog, and clicked "Commit", which I
assume means save, I got an error, but no stack trace I can send you.


Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.

To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Fri Jan 27 14:46:56 2006

This is an archived mail posted to the Subclipse Dev mailing list.