Mark Phippard wrote:
>> I didn't mean that they are the same, but there lot of similarity,
>>so why not to unify this in a common view? It should also improve user
>> I also would like to poit out that using modal dialog is generally
>>bad idea. Note that core Eclipse is avoiding using dialogs to present
>>any context-specific information (Properties and CVS/SVN History view
>>are good example of this approach).
>> So, you could create several sections in Properties view to show
>>variaous properties, locks, etc... and use single univied view for
>I do not agree that this would be desirable, or even a proper use of that
Any reasons why? Those all properties. Well, different kinds, but
still properties. So, put them under different sections in Properties view.
As of commit properties these could be also shown as regular
properties and you could provide custom editor for editing commit text
(the only popup dialog that can be optionally invoked for a long commit
>I also think that the two instances of using modal dialogs that you
>cite are appropriate, especially the one that allows you to edit the
>commit properties. The other dialog could be modeless but given its
>purpose and use, I do not think it is worth it.
Again why not? With Properties view user will have more responsible
UI. E.g. kick properties action from the repository view and properties
view will be populated asynchronously. I believe it would make much
sense to do it this way, then fix all the usability issues with
repository properties dialog, such as sorting properties by name, making
dialog resizeable, copy/change property values, etc.
Received on Tue Dec 6 04:04:06 2005