[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] alternative affected paths panel for resource history view

From: Eugene Kuleshov <eu_at_md.pp.ru>
Date: 2005-11-24 07:13:44 CET

  I've implemented this functionality and attached patch at
http://subclipse.tigris.org/issues/show_bug.cgi?id=424

  There are some restructuring in HistoryView to make
ChangePathsTableProvider selectable. I also made
ChangePathsTableProvider true viewer (so it probably should be renamed
to ChangePathsTableViewer).
  This patch is using same icons as pending view, so these icons may
need to be triked (e.g. to use the same overlays as the Sync view).
  Another thing is that to make data more observable I choose not to
compress folders with only one child and also remove all folders with no
childrens like those that appears on additions. This is of course on the
best effort because LogEntryChangePath does not provide info about
resource type (e.g. folder or file or properties, see
ChangePathsTreeContentProvider.getGroup() and
ChangePathsTreeViewer.ChangePathLabelProvider.getImage()), but I still
think that such representation is quite handy.

  regards,
  Eugene

Eugene Kuleshov wrote:
> Mark Phippard wrote:
>>> If there is an interest, I can wrap it up and add a property to the
>>> resource history view menu (Layout -> Flat or Compressed Folders).
>>>
>> By flat, you essentially mean the way it is currently? Obviously that
>> would be the ideal.
>>
> Right. I was going to make this optional, so user can choose.
>> I forgot a couple of questions. In the tree view, how do you plan on
>> representing something like the copy information? Perhaps add it in parenthesis?
> Right. Copy info just added after resource name.
>> Also, what about folder changes?
> That is why I've asked how to find if log entry is a folder or not.
> I can actually get a RemoteResource for each log entry and that give
> enough info, but it is very slow to do it one by one. So, I wonder if
> there is a better way, e.g. get all remote resources in one call.
> As a simplest way I can do some heuristics based on the presence of
> the folder's path in a log. In any case user would have choice to
> switch to flat view.
>> Finally, the log view has a couple of actions that we do not already have icons for. I know there is a 'R'eplaced action and I think there is at least one more.
>>
> It would be nice if these actions were documented in javadoc or even
> better if log entry would use some kind of enumeration for this.
> Currently I just used icons from pending view and was thinking if it
> would be better to use same overlays as on sync view (e.g. left blue
> arrow with +, - and no sign in them).
> By the way, what will be in a copy info for R action?
>>> Though there is an issue that I don't know how to resolve efficiently.
>>> The problem is that LogEntryChangePath class does not have information
>>> if resource is a folder or file and also if change were about file or
>>> about properties. Can someone advise on this?
>>>
>> This is an insurmountable problem. If you monitor the Subversion lists at
>> all you would see that this comes up regularly for a variety of reasons.
>> The svn log command, even at the API level, does not have this
>> information. I believe it does not exist at the wire protocol level
>> either so it cannot be added until a Subversion 2.0 release.
>>
> I see...
>
> regards,
> Eugene
>
>
>
Received on Thu Nov 24 17:13:44 2005

This is an archived mail posted to the Subclipse Dev mailing list.