[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] New JavaHL methods for SVN_ASP_DOT_NET_HACK not implemented correctly

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-10-27 19:40:17 CEST

The way the new methods for isAdminDirectory() and getAdminDirectoryName()
were added to the JavaHL SVNClientSynchrnonized class does not follow the
normal convention of that class and how it implements methods. Actually,
I do not think they will even work, because there is no "native" C++ class
that backs this class.

Subclipse uses this version of the class, so this needs to be resolved
prior to 1.3.

Thanks

Mark

Patch attached.

Index: org/tigris/subversion/javahl/SVNClientSynchronized.java
===================================================================
--- org/tigris/subversion/javahl/SVNClientSynchronized.java (revision
17058)
+++ org/tigris/subversion/javahl/SVNClientSynchronized.java (working
copy)
@@ -59,7 +59,13 @@
      * on Windows.
      * @since 1.3
      */
- public native String getAdminDirectoryName();
+ public String getAdminDirectoryName()
+ {
+ synchronized(clazz)
+ {
+ return worker.getAdminDirectoryName(name);
+ }
+ }
 
     /**
      * @param name The name of the directory to compare.
@@ -67,7 +73,13 @@
      * administrative directory.
      * @since 1.3
      */
- public native boolean isAdminDirectory(String name);
+ public boolean isAdminDirectory(String name)
+ {
+ synchronized(clazz)
+ {
+ return worker.isAdminDirectory(name);
+ }
+ }
 
     /**
      * Returns the last destination path submitted.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Fri Oct 28 03:40:17 2005

This is an archived mail posted to the Subclipse Dev mailing list.