> > I've attached another patch which implements #1. However, it loses
> > stderr, which I think should be reported alongside stdout using
> > CommandLine.notifyFromSvnOutput(). However, there is a
> > with the coalesceLines behavior, so I'm posting the patch
> for review
> > of the general approach before digging in deeper to accomodate the
> > notification. This general fix will likely resolve the
> failure of the
> > SvnAnt <add> test, but ought to be considered as a general
> change in
> > behavior. Note that in the long term, when svn is fed multiple
> > arguments and spits out warnings for some and acts on
> others, it will
> > eventually return an exit code for failure; however, this
> is not the current behavior (as of Subversion 1.3).
> > After thinking on this specific test failure for a while, it seems
> > that the root cause is the fact that 'svn info' is being
> invoked on an
> > unversioned resource -- which means that the implementation of
> > CmdLineClientAdapter.getStatus(File) and/or CmdLineStatuses() is
> > just plain wrong (at least with modern versions of Subversion).
I haven't too much time to think about your patch yet, I was just a bit
surprised about the test failures.
I thought they all pass.
Well, they actually do, at least in my environments.
I've re-tested WinXP and debian/unstable both cmdLine and javahl. All four
test with 0 failures.
Both OSes with svn client 1.2.3
Was there some intentional change in behaviour of cmdline in newer
subversion releases ?
In the 1.2.3 the svn info does print the "(Not a versioned resource)" but it
seems it outputs it to stdout not stderr,
so the cmdLineAdapter feels happy.
Received on Fri Oct 14 17:55:36 2005