RE: [Subclipse-dev] [PATCH] New svnant task to fetch WC summary status

> Martin,
>
> I did plug in JavaSVN, but it was quick and dirty.... and not
> really complete. There is an ant property "javahl" that can
> be set to false if
> you want to use the cmd-line adapter. Now that there are 3 svn
> implementations this needed some work if the user should be
> allowed to make the choice. I'm not sure what the nicest way
> to do this is.
>
> If you need any work done, have any questions, etc ...let me know.
>
> Thanks,
> Matt

Sure,

I took your patch and started to review and commmit it but then I slightly
deviated and first fixed the svnClientAdapter so all svnant test could pass.

After all, I've commited to trunk the "plugged-in" javasvn, but as temporary
solution only.

The question is exactly that you are asking:
how to provide ant user the option to choose 1 of 3 client adapter
implementations.

As a temporary solution I introduced there another "javasvn" attribute to
ant task, so now when you want
to go JavaSVN way you have to specify "javahl=false javasvn="true".
But I don't really like it.
Any more elegant proposal ? (I was thinking of parameter with 3 possible
values, but I'm not sure whether I like it either)

Martin
Received on Tue Aug 30 21:45:30 2005