Mark Phippard wrote:
>> I've put together some prototype for the approach we have discussed
>>for AbstractJhlClientAdapter. Basically it is what user would do
>>manually. See patch attached.
>> Current limitations are all your edge cases, some logging in DirUtils
>>and progress indication for DirUtils functions.
>> Present code also always using copy + delete in place of rename().
>> If you ok with doing something like this I can pull up methods to
>>handle temp location to common adapter class (to make it work for
>>cmdAdapter) and check what should be done in the UI.
>I took your prototype and made my own that I have attached. It
>demonstrates the idea that I had about putting the code in the Abstract
>class and conditioning it. This would just make it easy for different
>adapters to use or not use this code.
Right. I meant something saying about pulling it up.
>In general I am fine with this as long as it works.
>As for the edge cases, I wouldn't code for them initially, I would just
>test them. I think that Subversion itself can handle most of them. The
>EOL chars is probably the only one it can't and that seems like an extreme
>edge case. The problem would only be if the files you already had did not
>have the same EOL chars that Subversion was going to make the file in the
>Does the Java code you are proposing work consistently across platforms?
>For example, on Windows if you copy a folder structure on top of an
>existing one, Windows "merges" the results. On Linux and OS X, the
>existing structure is replaced. So if you copy a folder with 1 file on
>top of a folder with 5 files you get a folder with 1 file. On Windows,
>you either have a folder with 5 or 6 files. The Windows behavior is what
>we would need here.
>If you want to just get the adapter code worked out, I can probably do the
>UI. Although I imagine you need it in order to test.
Sure. I'll do some more testing. I'll make standalone test case for
DirUtils and will check it on win32 and linux. We'll have to find
someone to test it on OS X.
Received on Tue Aug 23 02:36:16 2005