[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Stats display in JhlNotificationHandler

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-08-10 14:39:16 CEST

"Martin Letenay" <mle@whitestein.com> wrote on 08/10/2005 04:33:34 AM:

> The JhlNotificationHandler#logStats() is propagating the statistics
> through the logMessage().
> It's a bit confusing, since e.g. the UpdateResourcesOperation intercepts
> logMessages to display them in the progress dialog.
> And after introduction of this update(File[]) way of performing update,
> these statistic are displayed in the progress dialog...
> Shouldn't we rather use logCompleted() (actually super.logCompleted())
> of logMessage() there ?

I am not sure I understand what that would accomplish. When I did the
stats, that just seemed the most appropriate way to do it. I was probably
assuming logCompleted() has a special meaning and might be doing something
extra. Is the issue just that the stuff you are doing with the progress
dialog grabs the logMessage() output but not the logCompleted()? If so,
feel free to just make the change.


Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
Received on Wed Aug 10 22:39:16 2005

This is an archived mail posted to the Subclipse Dev mailing list.