Re: [Subclipse-dev] [PATCH] Use SVNConstants.SVN_DIRNAME instead of ".svn" string literal

Mark Phippard wrote:
> Ideally the patch should come through as an attachment, but I can cut
> & paste.

That's strange. I sent it as attachments (three, actually, one for each
of the svnClientAdapter/src, subclipse/core/src, and svnant/src
directories), and the copy that got mailed back to me shows up fine as
attachments. Are you seeing it as inline patch straight in the mail
message? I sent it with Thunderbird on a windows box -- perhaps there's
something wrong with the way I have it configured?

> Thanks for it nonetheless. I will take a look and try to get it
> applied.

Thanks, I appreciate that. One less thing for me to worry about when
your next rev comes out. I forgot to mention, the patch was generated
against the 0.9.31 tag, not against trunk. Is that a problem?

> Keep in mind that in your scenario, you will also need to build the
> JavaHL DLL with this change in addition to the Subclipse change you
> provided.

Yeah, that was the first thing I did -- I didn't mean to imply that this
patch was sufficient, just necessary.

- Marc
Received on Fri Jul 8 20:56:08 2005