[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] New feature "Set Log Comment"

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-06-23 19:28:49 CEST

On Thu, 2005-06-23 at 11:05 -0400, Mark Phippard wrote:
>Jesper Steen Møller <jesper@selskabet.org> wrote on 06/23/2005 04:52:57
>AM:
>
>> Hi Developers
>>
>> I've submitted this feature (issue 324 and 325) as two patches since
>> this is perhaps a controversial feature, and because I'm not sure about
>> the process for updating svnClientAdapter into trunk (do I just build a
>> new one and commit the jar?)
>>
>> If you guys like it, I'll commit it tonight.
>>
>> To test-drive it, simply right-click on a revision number in the History
>
>> View and choose "Set Log Comment". There's an extra 'are you sure'
>> confirmation, so you think twice before changing. Also, you need to hook
>
>> "pre-revprop-change" in you repository.
>>
>> I admit this is a personal twitch, since my colleagues are lazy when
>> writing commit comments, and I'm too lazy to add a suitable repository
>> hook for it.
>
>Thanks!
>
>I definitelty think it is a worthy feature, I do not see anything
>controversial about it.
>
>I added my review comments in the issues.

I haven't run the code, but conceptually this is a really nice usability
improvement. Setting the svn:log revprop is such a common operation
that having a custom UI which expedites the operation is a big plus.

You might want to consider having it grab the previous log first, and
adding support for Undo by saving the old log message in memory or
caching it on disk (perhaps just until Eclipse is restarted).
Received on Fri Jun 24 03:28:49 2005

This is an archived mail posted to the Subclipse Dev mailing list.