[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] open resource from change path list

From: Eugene Kuleshov <eu_at_javatx.com>
Date: 2005-06-19 16:01:33 CEST

Mark Phippard wrote:
> getRepositoryRoot() would only return null if you did not define a
> repository root in your SVN Repository "connection" in the repositories
> view. Right-click and do Properties and click the Browse button to define
> the root.
>
> You should probably change the patch to just check if it returns null, and
> then use getURL().
>
> In general, the repository root is a better URL to use then the value you
> get from getURL() because it is possible that the latter URL will not exist
> at the revision you are double-clicking and then you get a different error.

   Do you mean something like this?

Index:
C:/dev/eclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/history/LogEntryChangePath.java
===================================================================
---
C:/dev/eclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/history/LogEntryChangePath.java
(revision 1374)
+++
C:/dev/eclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/history/LogEntryChangePath.java
(working copy)
@@ -87,6 +87,9 @@
       */
      public SVNUrl getUrl() {
              SVNUrl repositoryRoot = getRepository().getRepositoryRoot();
+ if(repositoryRoot==null) {
+ repositoryRoot = getRepository().getUrl();
+ }
          if (repositoryRoot != null) {
              try {
                                  return new SVNUrl(repositoryRoot.get()+getPath());
Received on Mon Jun 20 00:01:33 2005

This is an archived mail posted to the Subclipse Dev mailing list.