[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Bug 279 fix proposal

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-06-10 15:47:43 CEST

"Martin Letenay" <mle@whitestein.com> wrote on 06/10/2005 04:44:56 AM:

> I've just joined the project and as a start I've took a look at some
> bugs whether I can fix some.
> So I've picked this one:
> - Dir not decorated when file is deleted
> The problem is that when a resource stored in svn is being deleted, to
> parent directories as dirty,
> the resource cannot be deleted directly but rather turned into
"phantom". (See
> Resoure#deleteResource)
> The Resource#synchronizing(boolean) is checked wheter it can be turned
> phantom, which futher checks for presence of non-empty getSyncInfo().
> And there lies the problem, the syncInfo is always empty.
> I've tried to trace it down where it might get set and have found that
> PersistantResourceVariantByteStore#setBytes is the only reasonable place
being used.
> However the SVNWorkspaceSubscriber does not use this
> PersistantResourceVariantByteStore but rather
> which does not
> maintain the resource's syncInfo.
> When I replaced the remoteSyncStateStore in SVNWorkspaceSubscriber with
> PersistantResourceVariantByteStore everything starts to work as
> when file is deleted, it is converted into phantom and parent resources
> marked as dirty ...
> However I have absolutely no idea about other potential (negative)
> consequences of replacing SessionResourceVariantByteStore with
> PersistantResourceVariantByteStore,
> my knowledge of eclipse platform is very limited here ...
> Could you guys take a closer look whether such fix makes sense ?

Is there more to the patch? When I try this, everything seems like it is
working the way it already does. If I delete a class, I do not see the
folders that contain it become decorated. Also, I thought the class you
changed was only used by Synchronize, so I do not see how it would effect
the general decorators.

I am assuming there is more than one class changed by your patch, and you
meant to include more.


Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
Received on Fri Jun 10 23:47:43 2005

This is an archived mail posted to the Subclipse Dev mailing list.