[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: [PATCH] Re: New Subclipse Release coming

From: Andy Cutright <Andy.Cutright_at_borland.com>
Date: 2005-04-07 00:47:52 CEST

as an observer, i'd like to second that. we're leveraging the core in a
server, the server may be operating in an environment that has no GUI
sytem installed, in which case, any GUI initialization that's causing
say the AWT to fire up is going to cause the VM to fail to start,

cheers,
andy

> -----Original Message-----
> From: Mark Phippard [mailto:MarkP@softlanding.com]
> Sent: Wednesday, April 06, 2005 11:28 AM
> To: dev@subclipse.tigris.org
> Subject: Re: [PATCH] Re: New Subclipse Release coming
>
> The core plugin does not currently have any dependencies on
> Eclipse UI
> plugins so I would say that means there should not be any UI added to
> core.
>
> Mark
>
>
> Panagiotis Korros <panagiotis.korros@gmail.com> wrote on 04/06/2005
> 02:49:17 AM:
>
> > I gave your patch a quick look. It seems ok.
> >
> > The only think I noticed is that you have ui code residing
> in the core
> plugin.
> >
> > The usual eclipse conventions are never to have ui in the
> core plugin so
> as
> > the core can run headless.
> >
> > I don't know if that is a requirement for subclipse. We may
> already have
> ui
> > code in the core plugin.
>
> > On Apr 6, 2005 3:03 AM, Magnus Naeslund(t) <mag@fbab.net> wrote:
> > Mark Phippard wrote:
> > >
> > > I was hoping that Panagiotis would review it. Also, he has commit
> > > authority so he can just commit both of them whenever he
> feels like
> it. As
> > > long as you both test that your patch does nothing to
> make Eclipse
> 3.0.x
> > > stop working, I do not have any objections.
> > >
> >
> > Here's the polished auto-add patch up for review:
> >
> >
> http://subclipse.tigris.org/nonav/issues/showattachment.cgi/39
> /subclipse-
> > autoadd-rc3.diff
> >
> > It's on top of Panagiotis auto-share work, but a bit more simplified
> > since my latest patch. Easier to follow too, hopefully.
> >
> > I've tested both functionalities after my changes, and they
> work fine.
> >
> > I've also tested with Eclipse 3.0.2 and everything seems to
> work fine as
> > far as I can tell. It just doesn't have the new
> functionality since it
> > doesn't support the 3.1 style metadata tracking.
> >
> > Eyeing thru the code I can't find anything in my new code
> that could be
> > even touched by running 3.0.x except the simple dialog
> hooking stuff.
> > But since nothing is using that except my code (that is
> dead in 3.0.x)
> > that won't cause any problems.
> >
> > My evaluation is that it won't affect anyone except 3.0.x subclipse
> > developers that will see "Unknown attribute 'metaFilePaths'" in
> plugin.xml.
> >
> > So if Panagiotis is happy, he can apply it...
> >
> > Regards,
> > Magnus
>
> >
> >
> >
> > --
> > Take back the web http://www.getfirefox.com
> >
> >
> ______________________________________________________________
> _______________
> > Scanned for SoftLanding Systems, Inc. by IBM Email Security
> Management
> > Services powered by MessageLabs.
> >
> ______________________________________________________________
> _______________
>
> ______________________________________________________________
> _______________
> Scanned for SoftLanding Systems, Inc. by IBM Email Security
> Management Services powered by MessageLabs.
> ______________________________________________________________
> _______________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>
>
Received on Thu Apr 7 08:47:52 2005

This is an archived mail posted to the Subclipse Dev mailing list.