[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commit dialog has all files selected by default

From: Jesper Moller <jesper_at_selskabet.org>
Date: 2005-03-21 16:25:07 CET

(Moved from issues-list til dev)

>"Adriaan Peens-Hough" <IT3APH@puknet.puk.ac.za> wrote on 03/17/2005:
> i find it particularly annoying that the commit dialog has all
> (including unversioned files!) selected by default. doesn't this bother
> anyone else? it's really easy to hack, so i can't imagine there's a
> fundamental reason why it shouldn't be otherwise...

Mark Phippard <MarkP@softlanding.com> wrote on Thu, 17 Mar 2005:

>I made the decision that the dialog ought to have all items selected by
>default. In Eclipse, I think that is the right decision. You have two
>distinct ways (svn:ignore and Preferences) to automatically ignore
>certain files, and Eclipse also adds its own in that "derived" files
>like .class files are automatically ignored. Given all of these
>options, in my opinion the correct default behavior is to select all

True, these options exist. The effect of automatically checking the unversioned resources is often a surprise, and sometimes a bother IMHO.

Take into consideration:

A) The command line behaves differently (ignores unversioned resources)

B) The Eclipse CVS client specifically asks the user in a separate dialog.

C) TortoiseSVN has an option to show unversioned resources, and keeps these unchecked by default (IIRC).

D) I can see that people are falling into this trap regularly (at least my colleagues are, even the smarter ones)

I think the Principle of Least Surprise would instruct us to warn the user, and ask, perhaps with an option to turn the warning off.

Just my 2 Ýre (= 0.02 krone)

Received on Tue Mar 22 02:25:07 2005

This is an archived mail posted to the Subclipse Dev mailing list.