[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC][PATCH] Subclipse "autoadd" functionality

From: Panagiotis Korros <panagiotis.korros_at_gmail.com>
Date: 2005-03-17 13:40:54 CET

I totally agree. I proposed to commit the patch but there were some objections.

Personally I think it is safe to commit. It will only add 1 warning
about the the extra attributes in plugin.xml to subclipse developers
that use eclipse 3.0.

On Thu, 17 Mar 2005 13:06:51 +0100 (CET), Magnus Naeslund(w)
<mag@fbab.net> wrote:
>
> Panagiotis Korros said:
> > Ok I got it now.
> >
> > I would be nice if you could keep as much of the cvs code as possible
> > because it would be easier that way to integrate both patches and use
> > the same job to do both tasks.
> >
> > The metaFilesDetected method could start a job to do both autoshare
> > and autoadd. So suggest to keep the CVS code (my patch) and merge your
> > code into the job run method.
> >
> > The run method could check if the project is already committed (and
> > share it) or it is a new project (and add it).
> >
>
> Yes, this is the way to do it, are you committing your patch to head
> anytime soon, so I can code from that?
> I think that would be better than to combine two similar but distinctly
> different features in the same patch...
>
> Magnus
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>

-- 
Take back the web http://www.getfirefox.com
Received on Thu Mar 17 23:40:54 2005

This is an archived mail posted to the Subclipse Dev mailing list.