[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Synchronize View Problems

From: Panagiotis Korros <panagiotis.korros_at_gmail.com>
Date: 2005-02-19 11:14:54 CET

Hi Mark,

I am sorry I didn't respond earlier but I was very busy at work. Today
I managed to look at the sync code and I will try to explain what is
going on.

The Sync view uses the IResource[]
SVNWorkspaceSubscriber.members(IResource resource to find out the
resources contained in a container and then it asks the SyncInfo for
those resources. These resources are the resources that exists locally
+ the resources that exists only in the repository (added) + the
resources that have been locally removed (outgoing deletions or
missing files).

The current implementation of this method misses to add the locally
removed files. So the sync view never asks the SyncInfo for these
resources.

These are the lines that somehow must be implemented in subclipse
(copied from the CVS subscriber)

//TODO: add local changed resources (they may not exist locally)
//allMembers.addAll(Arrays.asList( localSyncStateStore.members( resource ) ) );

In subclipse we don't have a localSyncStateStore. We use the Status
Cache to keep state information. I think that we should refactor the
Status Cache to be more like a Tree Status Cache (something like
ResourceVariantByteStore) that keeps state information but also keeps
information about deleted / missing files. This info can be obtained
from the 'svn status' command allready executed to get status for the
resources.

This is the first step that we have to do to fix this problem. Then we
can implement the commented part of the resource change listener.

Regards, Panagiotis

-- 
Take back the web http://www.getfirefox.com
Received on Sat Feb 19 21:14:54 2005

This is an archived mail posted to the Subclipse Dev mailing list.