[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: getRevision, accidentally "sent" that last message too soon.

From: Jennifer Bevan <jen_at_alouysius.net>
Date: 2005-01-12 09:00:48 CET

My bad. Anyway, it turns out that the fix was Really Simple; I just
hadn't followed the inner classes properly before. So, the DateSpec
inner class of SVNRevision has its own toString() method, which
was specifying an output format string that svn doesn't like. So, I changed
that, and my command line client works great. The weird thing is that
in the format, you actually don't need the quotes inside of the curly
braces,
and if you do have them, it doesn't work. I think something about the
CommandLine:execProcess()'s use of an ArrayList might make it not
necessary for the programmatic API. Anyway.

Here's the patch, and thanks for the info about the timezone,
-Jennifer Bevan

Index: SVNRevision.java
===================================================================
--- SVNRevision.java (revision 1202)
+++ SVNRevision.java (working copy)
@@ -115,7 +115,7 @@
 
         public String toString() {
             
- SimpleDateFormat dateFormat = new SimpleDateFormat("EEE, d
MMM yyyy HH:mm:ss Z", Locale.US);
+ SimpleDateFormat dateFormat = new
SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z", Locale.US);
             return '{'+dateFormat.format(revDate)+'}';
         }
 

Mark Phippard wrote:

>Jennifer Bevan <jen@alouysius.net> wrote on 01/11/2005 04:03:24 PM:
>
>
>
>>Hmmm. I might not be being clear. On the command line, I can put
>>in dates using an allowed format using -r { datestring }. What I'm
>>having a problem with is programmatically using
>>SVNRevision.getRevision(datestring), which reads in a SHORT/SHORT
>>format string. svnClientAdapter then, when I create a log command
>>using the SVNRevision instance, creates a command using
>>SVNRevision.toString(), which creates a datestring that is not parseable
>>by svn. By asking the logCommand to print its command, I get:
>>
>>
>
>I understood what you were saying. I was under the impression you were
>working on a patch and were just confused as to what to do. We do not use
>this feature in Subclipse to my knowledge.
>
>Mark
>
>
>
>_____________________________________________________________________________
>Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
>_____________________________________________________________________________
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
>For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>
>
>
Received on Wed Jan 12 19:00:48 2005

This is an archived mail posted to the Subclipse Dev mailing list.