[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Linked Resource MoveDeleteHook

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-01-10 16:20:11 CET

> I've been playing around a little with linked resources turned on, and
> noticed a small problem when you try to delete a project and also delete
> the contents. It appears to try to follow links. I don't know if it
> actually deletes the stuff inside these links (It didn't delete a
> readonly test file I had), but it still warns you that you are about to
> delete readonly files.
>
> The attached patch checks for liked resources first, and passes it back
> to the normal move/delete. I'd attach it inline if it wasn't for outlook
> would eat it, if it doesn't make it through I'll send it from another
> address.

I commited this patch and also restored the canHandleLinkedResources()
functionality.

I did some research in the change log to see why this was removed. It
looks like it was done by accident. There was a massive patch committed
in r712 that was the initial commit of the Synchronize action. There was
a lot of code removed from SVNTeamOperation in this commit, and this
little 1-line method was included in the delete.

So that explain why we thought this was working once and then it suddenly
stopped. Of course we probably would have always had this delete problem,
so this patch helps. Please submit more if you run into anything else. I
did some testing and all looked pretty good.

Thanks

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Tue Jan 11 02:20:11 2005

This is an archived mail posted to the Subclipse Dev mailing list.