[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposed patch to SVNClientAdapter

From: Brock Janiczak <brockj_eclipse_at_ihug.com.au>
Date: 2004-11-23 10:26:06 CET

It would actually be easier for us if we *didn't* ship subclipse with
javahl. If we forced the user to install javahl on their system path we
wouldn't have to use loadLibrary to load all the dependencies. Windows
should do all the hard work for us. Every release of subversion we have
to make sure we are loading the required dependencies and in the right
order. Why did we decide to continue shipping javahl for windows? I
can't remeber now. Prebuilt javahl binares are readily available from
the subversion site. If we made it clear how to install javahl, i don't
see the problem (we could possible put up a hint in the preference page
if javahl can't be found).

CÚdric Chabanois wrote:

> Please wait for comments from Panagiotis Korros or McClain Looney
> before committing your patch. They added these lines while correcting
> issue #83
>
> If I remember well, we don't load the libraries just to do extra checks.
> The problem is that (on windows), we deliver the dlls in
> <eclipse>\plugins\org.tigris.subversion.javahl.win32_0.9.22\
> But if we only loaded libsvnjavahl-1, other dlls (libapr ...) would be
> loaded by windows. And windows would not find these dlls because they
> are not in the path (or in current directory, or in the directory of
> the executable (java.exe or eclipse.exe, I don't know) )
>
> Windows is the only platform for which we deliver the dynamic
> libraries needed (because it is easy)
>
> CÚdric
Received on Tue Nov 23 20:26:06 2004

This is an archived mail posted to the Subclipse Dev mailing list.