[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Icon overlays

From: Robert Simmons <kraythe_at_arcor.de>
Date: 2004-09-25 14:06:42 CEST

Well it would take me a lot logner than a weekend to do it because I have to
first figure out what the hell its doing. I have a couple issues with it so

1) Code quality is low (sorry but true) I had to turn off almost every
compiler option (and I run with almost all of them on) to get less than 2000
warnings and when I ran it through CodePro advisor, it practically coughed
up blood.
2) Not very well commented.
3) I still have to figure out what this decorator Configurator does.

I have a good mind to rip it out and replace the whole thing with something
sane but then I would have to understand a lot more than I bargained for.

I'm not trying to be a jerk but I know that the code quality issue could be
one of the biggest problems with the project right now. The code from
Eclipse, on the other hand, is much more solid. (Hmm there is an idea maybe,
"borrow" the stuff from the CVS integration. =)) Code which has quality this
low can quite easily kill a product. I have seen it happen professionally
ten thousand times.

Furthermore, improving code quality is not a waste of time. It's critical to
maintaining the survivability of a product. Many developers see it as
"changing something that works." I see it as "fixing something that BARELY

Finally, the code complexity is just too high. I was glancing at some of the
views and they are far more complex than they need to be. Overall I would
not be surprised if the code base could be reduced by a third to a half with
some refactoring.

I don't think you will get Eclipse.org itself to switch away from CVS until
these issues are resolved. I know I'm new to this project but I have been a
professional consultant for 9 years now and I have written a book with
O'Reilly so I am not a complete newbie.

In postscript, I have to say that you can hold me up to the same candle I
hold up to you. I mailed everyone my SLeak and RegexTools plugins with the
soure included. Unpack it and check it against the compiler options I
suggested and then read through it. You will see I ask no more of anyone
else than I ask of myself.

-- Robert

> -----Original Message-----
> From: Brock Janiczak [mailto:brockj_eclipse@ihug.com.au]
> Sent: Saturday, September 25, 2004 00:40
> To: users@subclipse.tigris.org
> Subject: Re: Icon overlays
> Robert Simmons wrote:
> >=) Just wanted to know if anyone was working on it.
> >
> >
> >
> I was actually going to work on cleaning up the decorators this weekend
> (including adding icons), but i certainly don't mind if you do it!
> I will look at adding a preview and possibly coloured decorators (like
> in 3.1 M2) instead.
> Cheers,
> Brock
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Sat Sep 25 22:06:42 2004

This is an archived mail posted to the Subclipse Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.