[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python bindings API confusion

From: Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org>
Date: Sun, 27 Dec 2020 05:24:16 +0900

I'm sorry, but I'd like to make a correction.

On 2020/12/26 20:02, Yasuhito FUTATSUKI wrote:

> [[[
> Index: subversion/bindings/swig/python/svn/fs.py
> ===================================================================
> --- subversion/bindings/swig/python/svn/fs.py (revision 1884802)
> +++ subversion/bindings/swig/python/svn/fs.py (working copy)
> @@ -24,6 +24,14 @@
> ######################################################################
>
> from libsvn.fs import *
> +
> +# For API compatibility we should replace wrapper function entity before
> +# adding alternative names.
> +_svn_fs_commit_txn = svn_fs_commit_txn
> +def svn_fs_commit_txn(*args) -> "char const **, svn_revnum_t *":
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
To keep Python 2 compatibility, it is better to remove annotation.

This function definition was originally taken from SWIG generated module
file for Python 3, subversion/bindings/swig/python/fs.py, and then
I modified to adjust return value. It was a mistake.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsclub.org>
Received on 2020-12-26 21:28:11 CET

This is an archived mail posted to the Subversion Dev mailing list.