[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS

From: Johan Corveleyn <jcorvel_at_apache.org>
Date: Fri, 18 Dec 2020 01:41:44 +0100

On Fri, Dec 18, 2020 at 1:00 AM Johan Corveleyn <jcorvel_at_apache.org> wrote:
>
> On Fri, Dec 18, 2020 at 12:50 AM <jcorvel_at_apache.org> wrote:
> >
> > Author: jcorvel
> > Date: Thu Dec 17 23:50:27 2020
> > New Revision: 1884579
> >
> > URL: http://svn.apache.org/viewvc?rev=1884579&view=rev
> > Log:
> > * 1.14.x/STATUS: Add -1 vote to r1880192 (issue #4862), because the test
> > fails on Windows. Vote for the test fix (r1881985 group). If the test
> > fix gets enough votes too, my vote for r1880192 can be converted to +1.
> >
> > Modified:
> > subversion/branches/1.14.x/STATUS
> >
> > Modified: subversion/branches/1.14.x/STATUS
> > URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1884579&r1=1884578&r2=1884579&view=diff
> > ==============================================================================
> > --- subversion/branches/1.14.x/STATUS (original)
> > +++ subversion/branches/1.14.x/STATUS Thu Dec 17 23:50:27 2020
> > @@ -23,15 +23,17 @@ Candidate changes:
> > r1878997, r1879192, r1879474, r1879959 (Fix issue #4859)
> > Votes:
> > +1: julianfoad, hartmannathan
> > + -1: jcorvel (test FAIL on Windows;
> > + +1 if r1881985 group (see below) is backported too)
> >
> > * r1881985, r1882105
> > Follow up to r1880192: Fix an EOL issue in test on Windows.
> > Justification:
> > We should test correctly on Windows environment, too.
> > Depends:
> > - rr1880192
> > + r1880192
> > Votes:
> > - +1: futatuki
> > + +1: futatuki, jcorvel
> >
> > * r1875675
> > Rewrite load_normalize_node_props to avoid literal trailing spaces.
> >
>
> Just as a heads up: I was ready to vote for an approve r1880192 (issue
> #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> 1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
> test, which makes it fail on Windows. So it really needs to be
> accompanied by the r1881985 group.
>
> If anyone can add a third vote to the r1881985 group, they get the
> other approval as a bonus :-).
>
> (cc'ing Julian and Nathan personally, because they have voted already
> for the first issue, so already know the context)

A small addition: same issue for the 1.10.x backports of the same
revisions. I just added the nomination of the test-EOL-fix (r1881985)
to 1.10.x/STATUS, where it was not listed yet. If anyone goes through
1.14.x/STATUS for this, you might as well take a look at 1.10.x/STATUS
:-).

-- 
Johan
Received on 2020-12-18 01:42:03 CET

This is an archived mail posted to the Subversion Dev mailing list.