[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Patch] Introduce release mode configure script (Re: [Patch] Update the INSTALL file for SWIG bindings)

From: Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org>
Date: Wed, 2 Dec 2020 01:34:37 +0900

On 2020/11/17 11:01, Yasuhito FUTATSUKI wrote:
> On 2020/11/17 2:16, Daniel Shahaf wrote:
>> Yasuhito FUTATSUKI wrote on Sat, 14 Nov 2020 14:52 +0900:
>>> +++ subversion/bindings/swig/INSTALL (working copy)
>>> @@ -141,7 +141,15 @@
>>> - Make sure that Subversion's ./configure script sees your installed SWIG!
>>> + If you are using the distribution tarball and you want to use the language
>>> + bindings C source files shipped with it, you might need to pass the
>>> + --without-swig option to configure script to avoid detecting and checking
>>> + SWIG on your system. A Makefile generated by configure will prevent
>>> + building the language bindings if the configure script detect unsuitable
>>> + version of SWIG.
>>
>> I don't dispute the accuracy of this paragraph, but I think this API
>> isn't autotools-idiomatic.
>>
>> Generally, I'd expect --without-foo to short-circuit the probe for foo
>> and assume foo isn't found; i.e., if my system has an unsuitable
>> version of foo, I'd the default behaviour (given neither --with-foo nor
>> --without-foo) and the behaviour given --without-foo to be identical:
>> namely, behave as though foo isn't available (even if /usr/bin/foo
>> exists and is perfectly suitable).
>>
>> In particular, if my system has an unsuitable version of swig,
>> I wouldn't expect passing --without-swig to change configure's behaviour.
>
> Probably what is wrong here is that the configure script accepts
> --with-swig | --without-swig options and checks it in release mode.
>
> We never clean SWIG generated language bindings C source files on
> clean-foo targets in release mode Makefile. extraclean-foo targets do it,
> but they are only parts of the extraclean target which also removes all
> release mode stuff. So users never use SWIG in release mode actually.
>
> That is, r1876662 is not correct.

To fix it, I tweaked the configure script again.

The patch attached introduce "release mode" for configure generation.
With this patch, configure script generated by "autogen.sh --release"
does not have --with-swig|--without-swig option and never check SWIG
executable.

Could anyone please review this?

For backward compatibility to back port to 1.14.x, default for
--with-swig-perl, --with-swig-python, --with-swig-ruby are "auto",
i.e. search the target language, but I'd like to change them to "no" in
trunk, because I think those are optional feature.

Thanks,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsclub.org>

Received on 2020-12-01 17:36:28 CET

This is an archived mail posted to the Subversion Dev mailing list.