On 2020/11/13 15:20, Nathan Hartman wrote:
> On Thu, Nov 12, 2020 at 12:22 AM Yasuhito FUTATSUKI
> <futatuki_at_yf.bsdclub.org> wrote:
>>> +<p>This issue is fixed as 1.14.1. The SWIG version check is automatically
>>> +skipped if the SWIG-generated files are present when <tt>configure</tt> is
>>> +run. Also, the check can be skipped explicitly by passing the
>>> +<tt>--without-swig</tt> option to <tt>configure</tt>.</p>
>>> +
>>
>> This is not correct. The SWIG version check is not skipped even if
>> the SWIG-generated files exists, if SWIG is detected by configure,
>> and if the version of the swig detected is not suitable for the bindings,
>> the configure script prevent to build Python bindings.
>> To prevent the configure script detecting SWIG and checking its version,
>> still users must pass --without-swig to the configure script explicitly.
>
> Thank you. You are right.
>
> Please tell me if this text is better:
>
> [[[
>
> +<div class="h4" id="issues-other-without-swig">
> +<h4>Installed SWIG prevents building Subversion's Python 3 bindings
> + <a class="sectionlink" href="#issues-other-without-swig"
> + title="Link to this section">¶</a>
> +</h4>
> +
> +<p>When building Subversion from a 1.14.0 distribution tarball, you may not be
> +able to build Subversion's language bindings for Python 3 if
> +<tt>configure</tt> detects an unsuitable version of SWIG on your system. This
> +is a bug because the sources generated by SWIG for Python 3 bindings are
> +included with the release.</p>
> +
> +<p>For this situation, a workaround is available as of 1.14.1: pass the
> +<tt>--without-swig</tt> option to <tt>configure</tt>.</p>
> +
> +<p>See r1876662.</p>
> +
> +<p>The workaround does not apply in the following situations:</p>
> +
> +<ul>
> + <li>building Subversion from sources checked out from the repository, where
> + the SWIG-generated files are not included</li>
> + <li>building Subversion's SWIG bindings for Python 2.x, in which case SWIG
> + is needed to regenerate the language bindings because the included ones
> + target Python 3</li>
> +</ul>
> +
> +<p>In these cases, you will need a suitable version of SWIG:</p>
> +
> +<ul>
> + <li>To target Python 2: SWIG 2.0.0 through 3.x. (Note that
> + <tt>configure</tt> will allow SWIG 1.3.24 through 3.x, but SWIG 4.0.0 or
> + later are not supported for Python 2.)</li>
> + <li>To target Python 3: SWIG 3.0.10 or later.</li>
> +</ul>
> +
> +</div> <!-- issues-other-without-swig -->
>
> ]]]
This looks good to me. Thank you very much.
I think it is better if this note is included in the swig bindings
INSTALL file. (Yes, I overlooked when I commit r1876662.)
Cheers,
--
Yasuhito FUTATSUKI <futatuki_at_yf.bsclub.org>
Received on 2020-11-13 08:07:51 CET