On Wed, Oct 7, 2020 at 10:35 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>
> Daniel Shahaf wrote on Wed, 07 Oct 2020 14:22 +0000:
> > Since r1882293 effectively reverted this, I'm guessing there was some
> > transient error. However, ENOTIME to look into this, particularly as
> > I didn't get a copy of stderr.
> >
> > The relevant cron job is:
> >
> > # Puppet Name: Update our upcoming changes list
> > SVN=svn
> > 15 4 * * * chronic ~/src/svn/site/tools/generate-upcoming-changes-log.sh
> >
>
> The cron job is running on svn-qavm.apache.org as local user "svnsvn".
> For details, see the Puppet manifest in Infra's repo (I don't have the
> link, sorry).
This happened again in r1882961:
On Thu, Oct 29, 2020 at 12:28 AM <svn-role_at_apache.org> wrote:
>
> Author: svn-role
> Date: Thu Oct 29 04:28:02 2020
> New Revision: 1882961
>
> URL: http://svn.apache.org/viewvc?rev=1882961&view=rev
> Log:
> * upcoming.part.html: Automatically regenerated
>
> Modified:
> subversion/site/publish/upcoming.part.html
Which removed all the upcoming changes from that page. Like before, it
will probably (effectively) revert itself again the next time this job
runs.
Without diving deeper yet, the last line in
site/tools/generate-upcoming-changes-log.sh
unconditionally commits the changes to upcoming.part.html.
I think an error occurs in upcoming.py before any revisions are
printed and I am *guessing* it happens in
copyfrom_revision_of_previous_tag_of_this_stable_branch because the
<pre>..</pre> is empty and specifically the line
"Changes in ^/subversion/branches/1.14.x:" is not printed.
Probably generate-upcoming-changes-log.sh should check for success of
upcoming.py before committing.
Can't look into this further now but posting these notes here for my
own (and anyone else's) reference...
Nathan
Received on 2020-10-29 23:06:47 CET