[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: preparing for 1.14.1

From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Thu, 22 Oct 2020 00:56:29 -0400

On Wed, Oct 21, 2020 at 7:07 AM Stefan Sperling <stsp_at_elego.de> wrote:
> Since May we have accumulated quite a few fixes on the 1.14.x branch
> and there are still some outstanding backport proposals.
>
> I guess it is about time to focus on getting the remaining fixes
> merged and then begin a release process. Is anyone able to set
> aside some time for this? I would volunteer as a release manager
> for this patch release if nobody else wants to do that part.
>
> There are some fixes on the javahl-1.14-fixes branch which are not
> on trunk yet. They seem like good candidates for 1.14.1 so it would
> be good to get them merged to trunk and then nominated for backport.

Thank you for bringing this up.

A few weeks ago I synced site/staging to get ready to update release
notes for 1.14.1.

Below, list 1 shows the fixes already on the 1.14.x branch, waiting to
be released.

I also went through trunk and identified some revs that might be
interesting for backport nomination. That's list 2 below...

As you note, javahl-1.14-fixes is awaiting merge to trunk and backport
nomination.

I have been busy with an urgent project that hopefully is coming to a
successful conclusion in the next few days, so I look forward to
catching up on reviewing/testing (and release notes) soon.

Cheers,
Nathan

List 1: Already on 1.14.x branch:

 * r1877788
   Fix a broken link in a docstring.

 * r1877072
   svnmucc: Change an error message to state another possible cause of the
   error.

* r1877259
    Move variable declarations to the start of block the to fix
    syntax errors with VC9 (Visual Studio 2008).

 * r1876707, r1876734, r1877318, r1877712, r1878141, r1878142, r1878143,
   r1878144
   Various fixes for making the test suite run correctly with Python 3 on
   Windows.

 * r1876662
   Avoid check for SWIG version for Python bindings when --without-swig is
   passed.

 * r1876906
   Make gen-make.py --debug work with Python 3

 * r1876410
   Fix the .editorconfig stanza for Makefile's.

 * r1878413
   autogen.sh: Remove per SWIG bindings checked files on release mode.

 * r1878909, r1878918, r1878950
   Fix a number of thinkos in human-readable file size formatting.

 * r1879198
   Fix an invalid quoting in working copy upgrade system that only works
   because SQLite automatically fixed this. More recent SQLite functions
   will signal an error when deprecated features are disabled.

 * r1877960
   INSTALL (I.C.12): Add Note that non-release mode is required for building
   SWIG Python 2 bindings.

 * r1880374:subversion/libsvn_fs_fs
   Fix an uninitialized read in svn_fs_fs__index_append().

 * r1880886
   Fix crash in JavaHL JNI wrapper caused by object lifetimes

List 2: On trunk, possibly interesting for backport nomination:

------------------------------------------------------------------------
r1875675 | danielsh | 2020-03-25 17:41:36 -0400 (Wed, 25 Mar 2020) | 3 lines

* subversion/tests/cmdline/svnadmin_tests.py
  (load_normalize_node_props): Rewrite without literal trailing spaces, to
    prevent the bug fixed in r1875620 from recurring.

------------------------------------------------------------------------
r1875794 | hartmannathan | 2020-03-27 18:11:03 -0400 (Fri, 27 Mar
2020) | 9 lines

* tools/dev/unix-build/Makefile.svn: Run htpasswd with LD_LIBRARY_PATH set.
  This fixes a problem on my system where htpasswd could not find the db lib
  built by this makefile and therefore failed to load, preventing httpd setup
  and serf tests. See dev@ mail thread "Late night unix-build weirdness" on
  2020/03/27 archived at:
  https://lists.apache.org/thread.html/rcf296d047a9711fc99c7534487d79a6cbaaca47efbc9c962d2d7fce5%40%3Cdev.subversion.apache.org%3E

Reviewed by: stsp

------------------------------------------------------------------------
r1876455 | cmpilato | 2020-04-13 10:06:09 -0400 (Mon, 13 Apr 2020) | 5 lines

Allow the creation of a release tarball that supports py2 bindings.

* build/generator/gen_make.py
  (write_standalone): Allow environmental override of the SWIG_PY_OPTS
    value written to autogen-standalone.mk.

------------------------------------------------------------------------
r1877300 | futatuki | 2020-05-02 12:13:11 -0400 (Sat, 02 May 2020) | 3 lines

* subversion/tests/cmdline/svndumpfilter_tests.py (match_empty_prefix):
 Fix qualified name of exception

------------------------------------------------------------------------
r1877301 | futatuki | 2020-05-02 12:28:45 -0400 (Sat, 02 May 2020) | 4 lines

Follow-up to 1877300: Fix incorrect exception name.

* subversion/tests/cmdline/svndumpfilter_tests.py (match_empty_prefix)

------------------------------------------------------------------------
r1877310 | danielsh | 2020-05-02 20:39:09 -0400 (Sat, 02 May 2020) | 7 lines

Add a test for issue #4711, "invalid xml file produced by: svn log --xml
--verbose --use-merge-history --search".

* subversion/tests/cmdline/log_tests.py
  (log_with_merge_history_and_search): New test.
  (test_list): Run it.

------------------------------------------------------------------------
r1877794 | danielsh | 2020-05-15 16:56:31 -0400 (Fri, 15 May 2020) | 4 lines

* subversion/include/private/svn_sorts_private.h
  (*): Use Doxygen's comment leader for comments that incorporate doxygen
    syntax — not because Doxygen parses this file, but for $EDITOR's syntax
    highlighting.

------------------------------------------------------------------------
r1877953 | stsp | 2020-05-20 08:46:11 -0400 (Wed, 20 May 2020) | 27 lines

Fix an TypeError exception in 'release.py create-tag'.

Regular expression matching failed due to lack of an explicit encoding
for files modified during the post-release housekeeping step.

The exception was observed with Python 3.7.7 and looked as follows:

INFO:root:Bumping version numbers on the branch
Traceback (most recent call last):
  File "/home/stsp/svn/svn-trunk/tools/dist/release.py", line 1916, in <module>
    main()
  File "/home/stsp/svn/svn-trunk/tools/dist/release.py", line 1912, in main
    args.func(args)
  File "/home/stsp/svn/svn-trunk/tools/dist/release.py", line 1134, in
create_tag_and_bump_versions
    bump_versions_on_branch(args)
  File "/home/stsp/svn/svn-trunk/tools/dist/release.py", line 1108, in
bump_versions_on_branch
    str(args.version.patch), str(new_version.patch))
  File "/home/stsp/svn/svn-trunk/tools/dist/release.py", line 1078, in
replace_in_place
    replacement = re.sub(pattern, repl, line)
  File "/usr/local/lib/python3.7/re.py", line 192, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: cannot use a string pattern on a bytes-like object

* tools/dist/release.py
  (bump_versions_on_branch): Create temporary file handles with an explicit
   encoding argument (assume UTF-8).

------------------------------------------------------------------------
r1878084 | hartmannathan | 2020-05-24 12:09:35 -0400 (Sun, 24 May
2020) | 17 lines

Fix an inefficient way to fill an array of inherited properties.

The code that obtains inherited properties for servers that don't support the
capability used an inefficient way of array filling. At each iteration, all
previously added properties were moved one position to the right to maintain
depth-first order. As a solution, walk the array of iprop requests from the
end and get rid of extra copying of array elements.

* subversion/libsvn_ra_serf/inherited_props.c
  (): Remove unused 'svn_sorts.h' and 'private/svn_sorts_private.h' includes.
  (get_iprops_via_more_requests): Walk the array of iprop requests from the
   end.

Patch by: Denis Kovalchuk <denis.kovalchuk{_AT_}visualsvn.com>

Review by: brane

------------------------------------------------------------------------
r1878379 | futatuki | 2020-06-01 23:08:35 -0400 (Mon, 01 Jun 2020) | 33 lines

configure: Add new option to specify path to swig bindings targets

Before this commit, it was not possible to use distinct Python
installations for the build system and test suite on the one hand,
and for building language bindings against on the other hand.

So we introduce new variable "SWIG_PY_PYTHON" for a target of
the SWIG Python bindings and a configure option to specify it.
Also, for the symmetry we introduce "SWIG_PL_PERL" and
"SWIG_RB_RUBY" for the Perl and Ruby SWIG bindings, and options
to specify them.

* configure.ac ():
  - Use variables "SWIG_PL_PERL", "SWIG_PY_PYTHON", "SWIG_RB_RUBY" for
    targets of the SWIG Perl, Python, Ruby bindings instead of "PERL",
    "PYTHON", "RUBY".
  - Introduce --with-swig-perl, --with-swig-python, --with-swig-ruby
    options for setting variables "SWIG_PL_PERL", "SWIG_PY_PYTHON",
    "SWIG_RB_RUBY".

* Makefile.in, build/ac-macros/swig.m4 ():
  Use variables "SWIG_PL_PERL", "SWIG_PY_PYTHON", "SWIG_RB_RUBY" for
  targets of the SWIG Perl, Python, Ruby bindings instead of "PERL",
  "PYTHON", "RUBY".

* subversion/bindings/swig/INSTALL
  (BUILDING SWIG BINDINGS FOR SVN ON UNIX step 2):
  - Describe how to specify the path to the target language interpreters
    with the new options, instead of using environment variables.
  - Fix the name of glue libraries.

Review by: danielsh

------------------------------------------------------------------------
r1880178 | futatuki | 2020-07-22 23:57:14 -0400 (Wed, 22 Jul 2020) | 3 lines

* tools/dev/wc-format.py (get_format):
  Avoid comparison between str and int, which is not allowed on Python 3.

------------------------------------------------------------------------
r1881774 | stsp | 2020-09-16 15:47:46 -0400 (Wed, 16 Sep 2020) | 2 lines

* contrib/hook-scripts/case-insensitive.py: Convert to Python 3.

------------------------------------------------------------------------
r1882127 | brane | 2020-09-29 10:18:04 -0400 (Tue, 29 Sep 2020) | 8 lines

Detect the next major version of macOS in 'svn --version --verbose'.

* subversion/libsvn_subr/sysinfo.c
  (macos_version_number): Replaces macos_minor_version.
  (product_name_from_version): Replaces product_name_from_minor_version.
  (release_name_from_version): Replaces release_name_from_minor_version.
  (macos_release_name): Use the updated functions to detect macOS 11 Big Sur.

------------------------------------------------------------------------
r1882128 | brane | 2020-09-29 10:19:42 -0400 (Tue, 29 Sep 2020) | 6 lines

Silence OSX ranlib warnings about object files with no symbols.

* subversion/libsvn_subr/apr_escape.c
  (svn__fake__apr_escape): Add a dummy symbol to an otherwise
   empty compilation unit.

------------------------------------------------------------------------
r1882234 | futatuki | 2020-10-04 10:12:07 -0400 (Sun, 04 Oct 2020) | 11 lines

Fix file name to edit from utf8 to local style.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_file_externally):
  Apply svn_path_cstring_from_utf8() to target file name after escape_shell().
  (svn_cmdline__edit_string_externally):
  Fix order to apply svn_path_cstring_from_utf8() and escape_shell().

Suggested by: stsp (applying order of file name conversion)
Reviewed by: stsp (svn_cmdline__edit_file_externally)

------------------------------------------------------------------------
r1882321 | stsp | 2020-10-08 08:42:38 -0400 (Thu, 08 Oct 2020) | 11 lines

Display the relevant authz ruleset if an authz test in repos-test fails.

This makes it easier to diagnose test failures.

* subversion/tests/libsvn_repos/repos-test.c
  (authz_check_access): Add 'authz_contents' parameter. Display authz file
   contents in the generated error message when a test fails.
  (authz, test_authz_wildcards, test_authz_prefixes,
   test_authz_recursive_override, test_authz_pattern_tests,
   in_repo_authz, in_repo_groups_authz, groups_authz): Update callers.
Received on 2020-10-22 06:56:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.