[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_cmdline__edit_file_externally() may not be able to open the target file in locale other than UTF-8

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 14 Oct 2020 19:57:19 +0000

Yasuhito FUTATSUKI wrote on Wed, 14 Oct 2020 13:30 +0900:
> On 2020/10/08 13:58, Yasuhito FUTATSUKI wrote:
> > Then I'll try to resolve it by the way you suggest.
>

>
> log message:
> [[[
> Follow up to r1882234,r1882235,r1882313: Fix file name encoding issue
> when invoking editor on Windows.
>

> Suggested by jun66j5 (editor return value in find_editor_binary)
> ]]]
>
> However, I still have some considerations:

> Thanks,

Sorry, I don't have anything to say about the actual code change.

Just one syntax nitpick: contribulyzer parentheticals should be on
a separate line, otherwise they get treated as part of the author's name,
as in https://www.red-bean.com/svnproject/contribulyzer/detail/brane%28indentation%29.html.
(I made the same mistake myself crediting astieger.)

That tends to matter more when crediting partial committers or
non-committers, since then it splits their credits into multiple
contribulyzer entries. (E.g., Doug Robinson has three entries.)

Cheers,

Daniel
Received on 2020-10-14 21:57:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.