[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_cmdline__edit_file_externally() may not be able to open the target file in locale other than UTF-8

From: Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org>
Date: Thu, 8 Oct 2020 13:58:48 +0900

Hi,

On 2020/10/08 13:12, Jun Omae wrote:
> Hi all,
>
> On Sun, Oct 4, 2020 at 11:33 PM Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org> wrote:
>> I commited the v3 patch in 1882234.
>>
>> I confirmed that on Windows in CP932, both of with and without
>> the v3 patch, it cannot pass the file name to edit.
>>
>> For Windows I confirmed that it can be fixed by using _wsystem()
>> with WCHAR string, so I commited it in 1882235.
>
> I found a minor issue on Windows after r1882235.
>
> When the editor command (via SVN_EDITOR environment and --editor-cmd option) has
> non-ascii characters, it is unable to launch the editor.
>
> I think we should convert the editor command to UTF-16 encoding before passing it
> to _wsystem(), otherwise r1882235 should be reverted.

I confirmed it is a regression that introduced in r1882235. So I reverted it
in 1882313.

Then I'll try to resolve it by the way you suggest.

Thanks,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsclub.org>
Received on 2020-10-08 07:02:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.