Re: [PATCH] Support APR 1.4 for building on CentOS 7

Branko Čibej wrote:
> I'm not comfortable with copying whole swathes of APR into our code.

I have made a smaller version (attached), restoring support just back to
APR 1.4 (not 1.3), putting all the apr_escape code in one file (128
lines long), omitting EBCDIC support. Does that feel better?

> Adding escape_path to the editor invocations was a bug fix, and I'd
> argue that if someone wants to use an older APR, they can just live
> with that bug, too. [...]

That's a valid option but I feel it's a last resort. Having decided
this was our bug to fix, rather than one that we just inherited through
the dependency, then it would seem like a bad thing to provide a way to
build Subversion such that the bug that we declared "fixed" is not fixed
in that build configuration.

> [...] For the rest we'd still want to keep the APR >= 1.4 requirement and APR >= 1.5 as the recommended minimum, so for example, leave the get_deps.sh unchanged.

For the rest, this patch does exactly that.

Andrew Marlow wrote:
> sounds good to me. I've built recent versions of subversion on RHEL7 and
> it is a right pain in the neck, chasing those dependencies down to serf,
> especially since the last time I looked serf depended on python2 instead
> of python3. Your proposal gets my vote, FWIW.

Thanks.

How's this version for everyone?

- Julian