[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 9 Sep 2020 17:21:42 +0000

Branko Čibej wrote on Wed, 09 Sep 2020 09:39 +0200:
> On 09.09.2020 08:18, Daniel Sahlberg wrote:
> > For a regression test (as well as trying to pinpoint what goes wrong),
> > wouldn't it be enough if the cancel_func check for the presence of a
> > file in .svn/tmp (maybe even checking if it is open - in Linux that
> > should be easy enough to check in /proc/$PID/fd) and then signal to
> > cancel. That would "only" need a repository/file that is large enough
> > to trigger calling the cancel_func.
> Not even that. The cancel check function is provided by the caller (in
> the client context) and can return 'true' when the conditions are right.
> Finding the correct temp directory is a bit more involved though because
> it's platform-dependent (i.e., I'm not sure if APR can reliably tell us
> that).

Why would finding the correct temp directory be a problem? The file in
question isn't created in the system temp dir but in .svn/tmp/.
Wouldn't it always be created there?
Received on 2020-09-09 19:21:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.