Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

Fabrice Fontaine wrote on Mon, 31 Aug 2020 15:34 +0200:
> Le lun. 31 août 2020 à 04:40, Daniel Shahaf <d.s_at_daniel.shahaf.name> a écrit :
> > Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200:
> > > +++ b/build/ac-macros/macosx.m4
> > > @@ -38,7 +38,7 @@ AC_DEFUN(SVN_LIB_MACHO_ITERATE,
> > > AC_MSG_RESULT([yes])
> > > ],[
> > > AC_MSG_RESULT([no])
> > > - ])
> > > + ],[:])
> >
> > Isn't that going to DTWT when cross-compiling for a macosx target? In
> > that case SVN_HAVE_MACHO_ITERATE should possibly be defined, but won't be.
> I can add an AC_COMPILE_IFELSE mimicking the AC_RUN_IFELSE in the
> action-if-cross-compiling if you prefer this solution.

I suspect this wouldn't be correct, since if it were correct, whoever
wrote the existing AC_RUN_IFELSE() call would have used
AC_COMPILE_IFELSE() instead.

I assumed we'd need to add a way for cross-builds to explicitly set the
result of this check (e.g., by a new --with-* option). However, I'm
not an OS X user, so there may be another solution I'm unaware of.

Could an OS X user chime in, please?

Cheers,

Daniel
Received on 2020-09-02 04:01:24 CEST