Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf <d.s_at_daniel.shahaf.name>
wrote:
> Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400:
> > Committed in r1880374.
>
> Thanks. Nominate these for backport?
>
> My +1 on the FSFS part for 1.14.x. (ENOTIME to review the FSX part
> currently.)

For FSFS, +1.

For FSX, I'd like to experiment some more first.

Before I committed the patch, I ran the test suite on trunk with the
patch applied on [fsfs, fsx] x [local, svn, serf] and all tests
passed.

Now, before nominating for backport, I wanted to re-test on the 1.14.x
branch + the changes in r1880374. All tests pass for fsfs. But the fsx
tests are giving slightly different results on each run, with or
without the changes in r1880374: About 1 or 2 fails per run, different
tests each time.) I don't think this is related to the changes in
r1880374. I'll go into more detail in a new thread...

Again, all tests pass for fsfs.

Regarding backports, we actually have quite a few bug fixes in trunk.
It's on my TODO list to go through these and perhaps nominate some for
backport. Also there's a patch in our mailing list archive that IIRC
fixes some testsuite issues on Windows that needs to be committed.
It's on my TODO list to find it and commit it, unless someone does it
first.

Nathan
Received on 2020-07-31 01:17:26 CEST