Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append
From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Sun, 26 Jul 2020 23:29:39 -0400
On Sat, Jul 25, 2020 at 7:27 PM Orivej Desh <orivej_at_gmx.fr> wrote:
Thanks for your patches!
+1 to commit the first patch...
I'll review the second patch tomorrow (unless someone beats me to it).
I've reviewed the first one so far. In reviewing, my concern was
* If, by chance, it is non-zero, 'eof' prevails and the block is
* If, by chance, it is zero, the block is entered without testing
As you say, it's harmless. Nevertheless, I think the patch should be
I ran the test suite on latest trunk with this patch applied (fsfs x
This is an archived mail posted to the Subversion Dev mailing list.