Re: [PATCH] Remove references to tigris.org from website

On Tue, Jul 7, 2020 at 5:38 PM Daniel Sahlberg <daniel.l.sahlberg_at_gmail.com>
wrote:

> Hi,
>
> I've looked through the website and I propose a few administrative
> changes. It's my first patch so fingers crossed I have not messed up!
>

Thanks, Daniel. Your patch submission is fine, though I suspect that if in
the future you name your patch file such that it ends with ".txt",
(evicttigris.patch.txt) more email clients will allow the patch content to
be directly visible and reply-able. As it was, I was forced to "Download"
the patch and paste its content back into this reply mail in order to
review it contextually.

Index: publish/docs/community-guide/general.part.html
> ===================================================================
> --- publish/docs/community-guide/general.part.html (revision 1879610)
> +++ publish/docs/community-guide/general.part.html (arbetskopia)
> @@ -71,8 +71,8 @@ to contribute, then look at:</p>
>
> <ul>
> <li><p>The bugs/issues database
> - <a href="http://subversion.tigris.org/issue-tracker.html"
> - >http://subversion.tigris.org/issue-tracker.html
> </a></p></li>
> + <a href="
> https://issues.apache.org/jira/browse/SVN-4862?jql=project%20%3D%20SVN"
> + >https://issues.apache.org/jira/issues/?jql=project =
> SVN</a></p></li>
> </ul>
>
>

You are linking here to a different URL than is displayed in the link
text. Also, the spaces around the = sign in the link text will allow that
URL to wrap. Maybe use the URL "
https://issues.apache.org/jira/projects/SVN/issues" in both places instead?

> <p>To submit code, simply send your patches to
> Index: publish/docs/community-guide/releasing.part.html
> ===================================================================
> --- publish/docs/community-guide/releasing.part.html (revision 1879610)
> +++ publish/docs/community-guide/releasing.part.html (arbetskopia)
> @@ -156,7 +156,7 @@ alpha or beta release is announced.</p>
>
> <p>When the alpha or beta is publicly announced, distribution packagers
> should be firmly warned off packaging it. See <a
> -href="
> http://subversion.tigris.org/servlets/ReadMsg?list=announce&amp;msgNo=264"
> +href="
> https://mail-archives.apache.org/mod_mbox/subversion-announce/201106.mbox/%3CBANLkTi%3DhFhXwpyGKp7XOsL4j39tssD363A%40mail.gmail.com%3E
> "
> >this mail from Hyrum K. Wright</a> for a good model.</p>
>
> </div> <!-- alphas-betas -->
>

I like your choice of a new example email here.

> Index: publish/docs/community-guide/roles.part.html
> ===================================================================
> --- publish/docs/community-guide/roles.part.html (revision 1879610)
> +++ publish/docs/community-guide/roles.part.html (arbetskopia)
> @@ -114,8 +114,8 @@ href="<!--#echo var="GUIDE_GENERAL_PAGE" -->#light
> >section on lightweight branches</a>, and this mail:</p>
>
> <pre>
> - <a href="
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&amp;msgNo=132746"
> ->http://subversion.tigris.org/servlets/ReadMsg?list=dev&amp;msgNo=132746
> </a>
> + <a href="https://svn.haxx.se/dev/archive-2007-11/0848.shtml"
> +>https://svn.haxx.se/dev/archive-2007-11/0848.shtml</a>
> From: Karl Fogel &lt;kfogel_at_red-bean.com&gt;
> To: dev_at_subversion.tigris.org
> Subject: branch liberalization (was: Elego tree conflicts work)

And this is good, too.

>
Received on 2020-07-08 14:34:23 CEST