[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 26 May 2020 18:38:20 +0000

Nathan Hartman wrote on Mon, 25 May 2020 11:18 -0400:
> Bringing this portion from [1] back to this thread:
>
> On Sun, May 24, 2020 at 8:38 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Nathan Hartman wrote on Sun, 24 May 2020 18:28 -0400:
> > > Asking because I ran the latter on latest trunk with this change
> > > applied. (All tests passed.) Also from reading the code, including
> > > spelunking into the APR calls etc, I see no functional difference
> > > (except efficiency as stated).
> >
> > "except efficiency"?
>
> :-)
>
> I meant: I see no functional difference, except that this
> implementation should construct the array more efficiently than the
> previous one.

Thanks for clarifying. Based on the (snipped) context, I thought you
had been referring to some difference between davautocheck stsp's
Makefile's serf-check, especially given that the issues I was reporting
could be reproduced in unpatched trunk_at_HEAD [which, at the time, didn't
contain the patch in the OP] as well.
Received on 2020-05-26 20:38:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.