[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: One more issue in tests on Windows with Python 3

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Tue, 26 May 2020 08:23:29 +0200

On Tue, May 26, 2020 at 4:14 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
>
> On 2020/05/26 5:52, Yasuhito FUTATSUKI wrote:
> > On 2020/05/26 5:23, Johan Corveleyn wrote:
> >> On Thu, May 14, 2020 at 3:55 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
> >
> >> Hmm, I still get this test failure, with trunk_at_today, when running
> >> update_tests.py with ra_serf, with Python 3.8.2 on Windows.
> >>
> >> [[[
> >> C:\research\svn\dev\trunk>python win-tests.py -c --log-level=DEBUG -p
> >> --httpd-dir=C:\Apache2.4.43 --httpd-port=1234 --httpd-no-log -t update
> >> ...
> >> FAIL: update_tests.py 76: test filename with backslashes inside
> >> ]]]
>
> >> Any ideas? Is there something wrong with the fix of r1877712? Or is
> >> there some other code path that runs into the same issue that wasn't
> >> addressed by r1877712?
> >
> > Thank you for the report.
> >
> > I found there still exist that uses raw 'const char *' value, in
> > entries_dump() and tree_dump_dir(). So I'll fix them.
>
> I've made a patch address it. Could you please test the attached patch?

Yes, perfect. This fixes the update test. I will also apply this to my
1.14.0 while testing it for signing off on the release :-). Together
with other applied patches, and backported fixes from trunk that
should yield a fully successful test suite with Python 3 on Windows.

Thanks,

-- 
Johan
Received on 2020-05-26 08:23:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.