Re: One more issue in tests on Windows with Python 3

On 2020/05/26 5:23, Johan Corveleyn wrote:
> On Thu, May 14, 2020 at 3:55 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:

> Hmm, I still get this test failure, with trunk_at_today, when running
> update_tests.py with ra_serf, with Python 3.8.2 on Windows.
>
> [[[
> C:\research\svn\dev\trunk>python win-tests.py -c --log-level=DEBUG -p
> --httpd-dir=C:\Apache2.4.43 --httpd-port=1234 --httpd-no-log -t update
> ...
> FAIL: update_tests.py 76: test filename with backslashes inside
> ]]]
>
> dav-fails.log contains:
>
> [[[
> I: CMD: entries-dump.exe --tree-dump
> svn-test-work\working_copies\update_tests-76
> W: CWD: R:\test_release-p--httpd-dirC__Apache2.4.43--httpd-port1234--httpd-no-log-tupdate\subversion\tests\cmdline
> Traceback (most recent call last):
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\main.py",
> line 1927, in run
> rc = self.pred.run(sandbox)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\testcase.py",
> line 258, in run
> return self._delegate.run(sandbox)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\testcase.py",
> line 178, in run
> result = self.func(sandbox)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\update_tests.py",
> line 6382, in windows_update_backslash
> svntest.actions.run_and_verify_status(wc_dir, expected_status)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\actions.py",
> line 1605, in run_and_verify_status
> actual_entries = wc.State.from_entries(wc_dir_name)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\wc.py",
> line 744, in from_entries
> dump_data = svntest.main.run_entriesdump_tree(base)
> File "C:\research\svn\dev\trunk\subversion\tests\cmdline\svntest\main.py",
> line 929, in run_entriesdump_tree
> exec(''.join(filter_dbg(stdout_lines)))
> File "<string>", line 280
> SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes
> in position 10-11: truncated \uXXXX escape
> FAIL: update_tests.py 76: test filename with backslashes inside
> ]]]
>
> See entire dav-fails.log in attachment.
>
> Any ideas? Is there something wrong with the fix of r1877712? Or is
> there some other code path that runs into the same issue that wasn't
> addressed by r1877712?

Thank you for the report.

I found there still exist that uses raw 'const char *' value, in
entries_dump() and tree_dump_dir(). So I'll fix them.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>/<futatuki_at_yf.bsdclub.org>