[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Sun, 24 May 2020 18:28:51 -0400

On Sun, May 24, 2020 at 6:00 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Nathan Hartman wrote on Sun, 24 May 2020 12:10 -0400:
> > On Sat, May 23, 2020 at 8:38 PM Branko ─îibej <brane_at_apache.org> wrote:
> > > For my part, I just didn't get around to it. I think it should be committed.
> >
> > I committed it in r1878084.
> Thanks, Nathan. I'd have done this myself, but my build environment
> had bitrotted to the point that davautocheck didn't pass.

Uh oh, that sounds bad.

I haven't looked at davautocheck.sh before. Does it test anything that
tools/dev/unix-build/Makefile.svn doesn't? Asking because I ran the
latter on latest trunk with this change applied. (All tests passed.)
Also from reading the code, including spelunking into the APR calls
etc, I see no functional difference (except efficiency as stated).

Received on 2020-05-25 00:29:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.