[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix an inefficient way to fill an array of inherited properties

From: Branko Čibej <brane_at_apache.org>
Date: Sun, 24 May 2020 02:38:00 +0200

On 24.05.2020 00:17, Daniel Shahaf wrote:
> Branko Čibej wrote on Fri, 15 May 2020 17:07 +0200:
>> On 15.05.2020 16:54, Denis Kovalchuk wrote:
>>> Hello.
>>>
>>> I think that currently the code that obtains inherited properties for servers
>>> that don't support the capability uses an inefficient way of array filling.
>>> At each iteration, all previously added properties are moved one position to
>>> the right to maintain depth-first order. I think it's possible to provide a
>>> similar behavior walking the array of iprop requests from the end and get rid
>>> of extra copying of array elements.
>>>
>>> I've attached a patch.
>>
>> Looks like an obvious fix. +1
> Any reason this hasn't been committed?

For my part, I just didn't get around to it. I think it should be committed.

-- Brane
Received on 2020-05-24 02:38:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.